Hi Linus, On Mon, Mar 15, 2021 at 10:43 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Sun, Mar 14, 2021 at 1:05 AM Julian Calaby <julian.calaby@xxxxxxxxx> wrote: > > > I don't know if this is necessary for SDIO, but should the non-4329 > > compatibles have the 4329 compatible as an alternative? > > I can, and I guess I should add it, as I grep:ed and saw this: > > arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > compatible = "brcm,bcm4339-fmac", "brcm,bcm4329-fmac"; > > So from more to less specific. > > Yours, > Linus Walleij If it helps, the pattern I've seen before for this is: oneOf: - const: vendor,specific-device-1234 - items: - enum: - vendor,compatible-device-2345 - vendor,compatible-device-3456 - const: vendor,specific-device-1234 See https://elixir.bootlin.com/linux/v5.12-rc3/source/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml for an example. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/