Search Linux Wireless

Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
From: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 26 Feb 2021 14:16:12 -0700
Cc: mingo@xxxxxxxxxx, will@xxxxxxxxxx, kvalo@xxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, kuba@xxxxxxxxxx, ath10k@xxxxxxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <YDli+H48Ft3F6k9/@hirez.programming.kicks-ass.net>
References: <cover.1614355914.git.skhan@linuxfoundation.org> <a40d18bba5a52662ac8fc556e1fce3752ea08472.1614355914.git.skhan@linuxfoundation.org> <YDli+H48Ft3F6k9/@hirez.programming.kicks-ass.net>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 2/26/21 2:07 PM, Peter Zijlstra wrote:

On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote:

+		/* avoid false negative lockdep_assert_not_held()
+		 * and lockdep_assert_held()
+		 */


That's a coding style fail.


Checkpatch didn't complain. What's your preference? Does the
following work for you?

/*
 * avoid false negative lockdep_assert_not_held()
 * and lockdep_assert_held()
 */

thanks,
-- Shuah

Follow-Ups:
- Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
  - From: Peter Zijlstra

References:
- [PATCH v2 0/3] Add lockdep_assert_not_held()
  - From: Shuah Khan
- [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
  - From: Shuah Khan
- Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
  - From: Peter Zijlstra

Prev by Date: Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
Next by Date: Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables
Previous by thread: Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
Next by thread: Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]