Search Linux Wireless

Re: [PATCH v2 2/3] lockdep: add lockdep lock state defines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/26/21 11:03 AM, Johannes Berg wrote:

@@ -5475,7 +5476,7 @@ noinstr int lock_is_held_type(const struct lockdep_map *lock, int read)
  		/* avoid false negative lockdep_assert_not_held()
  		 * and lockdep_assert_held()
  		 */
-		return -1;
+		return LOCK_STATE_UNKNOWN;

I'd argue that then the other two return places here should also be
changed.


Makes sense.

Since lock_is_held_type() simply returns what  __lock_is_held() for the
other cases, __lock_is_held() is the one that needs changes to use these defines.

thanks,
-- Shuah







[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux