On 26.02.2021 08:12, Kalle Valo wrote: > Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> writes: > >> Now we have a generic D3 shutdown quirk, so convert the original >> approach to a PCI quirk. >> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> >> --- >> drivers/net/wireless/realtek/rtw88/pci.c | 2 -- >> drivers/pci/quirks.c | 6 ++++++ >> 2 files changed, 6 insertions(+), 2 deletions(-) > > It would have been nice to CC linux-wireless also on patches 1-2. I only > saw patch 3 and had to search the rest of patches from lkml. > > I assume this goes via the PCI tree so: > > Acked-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > To me it looks odd to (mis-)use the quirk mechanism to set a device to D3cold on shutdown. As I see it the quirk mechanism is used to work around certain device misbehavior. And setting a device to a D3 state on shutdown is a normal activity, and the shutdown() callback seems to be a good place for it. I miss an explanation what the actual benefit of the change is.
