Search Linux Wireless

Re: [PATCH 3/4] wilc1000: Check for errors at end of DMA write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2021-02-25 at 10:27 +0200, Kalle Valo wrote:
> David Mosberger-Tang <davidm@xxxxxxxxxx> writes:
> > +	for (i = sizeof(rsp) - 2; i >= 0; --i)
> > +		if ((rsp[i] & 0xf0) == 0xc0)
> > +			break;
> 
> No magic numbers. Please create proper defines for these.]
>
> +	if (rsp[i] != 0xc3 || rsp[i + 1] != 0x00) {
> 
> Same here.

Good points.  I'll change those, thanks.

  --david




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux