<Ajay.Kathat@xxxxxxxxxxxxx> writes: > On 25/02/21 5:06 am, David Mosberger-Tang wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> Julian, >> >> On Thu, 2021-02-25 at 08:19 +1100, Julian Calaby wrote: >>> Hi David, >>> >>> On Wed, Feb 24, 2021 at 6:56 PM David Mosberger-Tang < >>> davidm@xxxxxxxxxx> wrote: >>>> >>>> +#define ENABLE_CRC7 0 /* set to 1 to protect SPI commands >>>> with CRC7 */ >>>> +#define ENABLE_CRC16 0 /* set to 1 to protect SPI data >>>> with CRC16 */ >>> >>> Should these be Kconfig variables instead? >> >> I'd certainly like that. Ajay, would you be OK with that? >> > > Yes, I am fine with the changes to move as Kconfig variable. Kconfig is not ideal for configuring functionality, something like a module parameter is usually better. But why not just enable CRC always? Why would the user need to disable this? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
