Miaoqing Pan <miaoqing@xxxxxxxxxxxxxx> wrote: > There is a potential race condition between skb_queue_len() > and skb_queue_tail(), the former may get old value before > updated by the latter. > > So use skb_queue_len_lockless() instead. And also use '>=', > in case we queue a few SKBs simultaneously. > > Found while discussing a similar fix for ath10k: > https://patchwork.kernel.org/project/linux-wireless/patch/1608515579-1066-1-git-send-email-miaoqing@xxxxxxxxxxxxxx/ > > No functional changes, compile tested only. > > Signed-off-by: Miaoqing Pan <miaoqing@xxxxxxxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 3808a18043a8 ath11k: fix potential wmi_mgmt_tx_queue race condition -- https://patchwork.kernel.org/project/linux-wireless/patch/1613630709-704-1-git-send-email-miaoqing@xxxxxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches