On Tue, 2020-12-08 at 14:54 -0800, Muna Sinada wrote:
> Added necessary functions and attributes to be able to pass driver
> updated MU-EDCA parameters from mac80211 to user space.
Please write a proper commit message, in imperative voice.
> +/**
> + * cfg80211_update_muedca_params_event - Notify the updated MU-EDCA parameters
> + * to user space.
"Notify the ... to" sounds really odd to me - "notify userspace about
updated ..." or something?
Also this is missing a lot of commit message to explain what this does
and when it's needed.
> + *
> + * @wiphy: the wiphy
> + * @params: Updated MU-EDCA parameters
> + * @gfp: allocation flags
> + */
> +void cfg80211_update_muedca_params_event(struct wiphy *wiphy,
> + struct ieee80211_mu_edca_param_set
> + *params, gfp_t gfp);
that line breaking is awful
> @@ -1408,6 +1413,7 @@ enum nl80211_commands {
>
> NL80211_CMD_CONTROL_PORT_FRAME_TX_STATUS,
>
> + NL80211_CMD_UPDATE_HE_MUEDCA_PARAMS,
> /* add new commands above here */
a blank line would be nice
> * This is a u8 attribute that encapsulates one of the values from
> * &enum nl80211_sae_pwe_mechanism.
> *
> + * @NL80211_ATTR_HE_MUEDCA_PARAMS: MU-EDCA AC parameters for the
> + * %NL80211_CMD_UPDATE_HE_MUEDCA_PARAMS command.
That should explain the data type.
> * @NUM_NL80211_ATTR: total number of nl80211_attrs available
> * @NL80211_ATTR_MAX: highest attribute number currently defined
> * @__NL80211_ATTR_AFTER_LAST: internal use
> @@ -3025,6 +3034,7 @@ enum nl80211_attrs {
>
> NL80211_ATTR_SAE_PWE,
>
> + NL80211_ATTR_HE_MUEDCA_PARAMS,
> /* add attributes here, update the policy in nl80211.c */
blank line again
> +void cfg80211_update_muedca_params_event(struct wiphy *wiphy,
> + struct ieee80211_mu_edca_param_set
> + *params, gfp_t gfp)
line breaks are awful
probably should have tracing.
johannes
