Search Linux Wireless

Re: [RFC/RFT] p54: Fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2008-09-13 at 10:40 -0500, Larry Finger wrote:
> Michael Buesch wrote:
> > On Friday 12 September 2008 20:52:52 Larry Finger wrote:
> >> No, it won't avoid any casts. The program uses the data area 7 times 
> >> in native-cpu order, once as be32, and once in little-endian order 
> > 
> > Is the native use correct? Smells fishy.
> 
> It does to me as well.

I think we should assume fixed byte order unless the hardware is
programmed differently for big-endian hosts (e.g. Atheros chipsets can
byte-swap some registers).  If the driver is working on little-endian
systems, we should assume little-endian data unless testing proves us to
be wrong.

>  I just got a copy of Intersil's data sheet for
> the MAC and everything looks little endian, but until we get a tester
> with a big-endian machine, we won't know. So far, no volunteers have
> come forward.

I have a PowerMac and a Prism54 card, so I can test.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux