On Tue, 2021-01-26 at 21:55 +0100, Johannes Berg wrote: > On Tue, 2021-01-26 at 12:32 -0800, Jakub Kicinski wrote: > > On Mon, 25 Jan 2021 07:09:49 -0800 Eric Dumazet wrote: > > > From: Eric Dumazet <edumazet@xxxxxxxxxx> > > > > > > net/core/tso.c got recent support for USO, and this broke iwlfifi > > > because the driver implemented a limited form of GSO. > > > > > > Providing ->gso_type allows for skb_is_gso_tcp() to provide > > > a correct result. > > > > > > Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support") > > > Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx> > > > Reported-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > > Bisected-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > > Tested-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > > Cc: Luca Coelho <luciano.coelho@xxxxxxxxx> > > > Cc: linux-wireless@xxxxxxxxxxxxxxx > > > Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > > > Johannes, Eric tagged this for net, are you okay with me taking it? > > No strong preference here. > > I guess that really would normally go through Luca's and Kalle's trees, > but yes, please just take it, it's been long and it won't conflict with > anything. Yes, that's fine by me too. Just take it via net and we'll get it into our trees eventually. -- Cheers, Luca.