Hi, On Mon, 2021-01-25 at 12:07 +0300, Dan Carpenter wrote: > Hello Johannes Berg, > > This is a semi-automatic email about new static checker warnings. > > The patch 791daf8fc49a: "cfg80211: avoid holding the RTNL when > calling the driver" from Jan 19, 2021, leads to the following Smatch > complaint: > > net/wireless/nl80211.c:3242 nl80211_set_wiphy() > error: we previously assumed 'rdev' could be null (see line 3222) > > net/wireless/nl80211.c > 3221 > 3222 if (rdev) > ^^^^ > The patch adds a NULL dereference > > 3223 mutex_lock(&rdev->wiphy.mtx); Yeah. I realized this later, the "if" here is wrong. Current version has this unconditional :-) johannes
