Search Linux Wireless

Re: [PATCHv2] cfg80211: Skip key deletion for open associations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 26, 2021 at 1:21 AM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
>
> On Tue, 2021-01-26 at 00:50 +0530, chaitanya.mgit@xxxxxxxxx wrote:
> > From: Chaitanya Tata <chaitanya.mgit@xxxxxxxxx>
> >
> > From: Chaitanya Tata <chaitanya.mgit@xxxxxxxxx>
>
> That's broken, please check your git mail setup.
Fixed.
>
>
> >        * Delete all the keys ... pairwise keys can't really
> >        * exist any more anyway, but default keys might.
> >        */
> > -     if (rdev->ops->del_key) {
> > +     if (wdev->connect_keys && rdev->ops->del_key) {
> >
>
> This is wrong, wdev->connect_keys is not needed to make a secure
> connection.
Ah, I guess it's only for the WEP, right? From a quick look, we are not saving
connect params (connect.crypto), will take a deeper look, thanks.



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux