stf_xl@xxxxx wrote: > From: Stanislaw Gruszka <stf_xl@xxxxx> > > We have already WARN_ON(!qc) for non-QOS frame on txq->sched_retry path, > but we continue to process, what makes no sense since tid is not > initialized. Non QOS frame should never happen when aggregation > is enabled on queue, so do not process that. > > Patch should fix smatch warning: > drivers/net/wireless/intel/iwlegacy/4965-mac.c:2822 il4965_hdl_tx() error: uninitialized symbol 'tid'. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Stanislaw Gruszka <stf_xl@xxxxx> Patch applied to wireless-drivers-next.git, thanks. 4832bb371c41 iwl4965: do not process non-QOS frames on txq->sched_retry path -- https://patchwork.kernel.org/project/linux-wireless/patch/20210119100621.439134-1-stf_xl@xxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches