On Mon, 2008-09-15 at 17:27 -0400, John W. Linville wrote: > CC [M] drivers/net/wireless/libertas/wext.o > drivers/net/wireless/libertas/wext.c: In function ‘lbs_get_rts’: > drivers/net/wireless/libertas/wext.c:307: warning: comparison is always > false due to limited range of data type > > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> Acked-by: Dan Williams <dcbw@xxxxxxxxxx> > --- > drivers/net/wireless/libertas/wext.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/libertas/wext.c b/drivers/net/wireless/libertas/wext.c > index 1156be5..11297dc 100644 > --- a/drivers/net/wireless/libertas/wext.c > +++ b/drivers/net/wireless/libertas/wext.c > @@ -281,7 +281,7 @@ static int lbs_set_rts(struct net_device *dev, struct iw_request_info *info, > if (vwrq->disabled) > val = MRVDRV_RTS_MAX_VALUE; > > - if (val < MRVDRV_RTS_MIN_VALUE || val > MRVDRV_RTS_MAX_VALUE) > + if (val > MRVDRV_RTS_MAX_VALUE) /* min rts value is 0 */ > return -EINVAL; > > ret = lbs_set_snmp_mib(priv, SNMP_MIB_OID_RTS_THRESHOLD, (u16) val); > @@ -304,8 +304,7 @@ static int lbs_get_rts(struct net_device *dev, struct iw_request_info *info, > goto out; > > vwrq->value = val; > - vwrq->disabled = ((val < MRVDRV_RTS_MIN_VALUE) > - || (val > MRVDRV_RTS_MAX_VALUE)); > + vwrq->disabled = val > MRVDRV_RTS_MAX_VALUE; /* min rts value is 0 */ > vwrq->fixed = 1; > > out: -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
