On Tue, Jan 19, 2021 at 9:53 AM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Eric, all,
>
> Sorry we've been so silent on this.
>
> > --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
> > @@ -773,6 +773,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb,
> > unsigned int num_subframes,
> >
> > next = skb_gso_segment(skb, netdev_flags);
> > skb_shinfo(skb)->gso_size = mss;
> > + skb_shinfo(skb)->gso_type = ipv4 ? SKB_GSO_TCPV4 : SKB_GSO_TCPV6;
> > if (WARN_ON_ONCE(IS_ERR(next)))
> > return -EINVAL;
> > else if (next)
> > @@ -795,6 +796,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb,
> > unsigned int num_subframes,
> >
> > if (tcp_payload_len > mss) {
> > skb_shinfo(tmp)->gso_size = mss;
> > + skb_shinfo(tmp)->gso_type = ipv4 ?
> > SKB_GSO_TCPV4 : SKB_GSO_TCPV6;
> > } else {
> > if (qos) {
> > u8 *qc;
>
> This does fix the problems reported on iwlwifi, were you planning to
> submit it as a proper patch?
Sure, I will do, thanks !
