> -----Original Message----- > From: Brian Norris [mailto:briannorris@xxxxxxxxxxxx] > Sent: Thursday, January 14, 2021 3:05 AM > To: Pkshih > Cc: Yan-Hsuan Chuang; Kalle Valo; linux-wireless; Bernie Huang > Subject: Re: [PATCH v2 4/7] rtw88: replace tx tasklet with tx work > > On Wed, Jan 13, 2021 at 1:53 AM Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > > > > From: Po-Hao Huang <phhuang@xxxxxxxxxxx> > > > > Move tx tasklet to thread, by this we can reduce time spent on > > waiting for schedule and have better efficiency. > > > > Signed-off-by: Po-Hao Huang <phhuang@xxxxxxxxxxx> > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > I'm curious, why a bare kthread and not just a (WQ_HIGHPRI?) > workqueue? It seems like you're sort of reimplementing some of the > workqueue semantics with your SCHEDULED and RUNNING flags, when > queue_work() would do that for you. > Thanks for your advice. We'll do it in v4, since v3 has been sent, but not appear in patchwork. --- Ping-Ke
