On Thu, Jan 07, 2021 at 10:35:12PM +0530, M Chetan Kumar wrote: > Implements a char device for flashing Modem FW image while Device > is in boot rom phase and for collecting traces on modem crash. Since this is a network device, you might want to take a look at devlink support for flashing devices. https://www.kernel.org/doc/html/latest/networking/devlink/devlink-flash.html And for collecting crashes and other health information, consider devlink region and devlink health. It is much better to reuse existing infrastructure than do something proprietary with a char dev. Andrew