Search Linux Wireless

Re: [PATCH 3/6] iwlwifi: Allow per-device fwcfg files.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/30/20 5:19 PM, Julian Calaby wrote:
Hi Ben,

On Thu, Dec 31, 2020 at 11:17 AM <greearb@xxxxxxxxxxxxxxx> wrote:

From: Ben Greear <greearb@xxxxxxxxxxxxxxx>

This allows one to set the NSS and some
other low-level features for ax200 radios.

Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
---
  drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c | 8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
index 223c716d9fce..e2ae509d1650 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
@@ -246,12 +246,16 @@ void iwl_dbg_cfg_load_ini(struct device *dev, struct iwl_dbg_cfg *dbgcfg)
         const struct firmware *fw;
         char *data, *end, *pos;
         int err;
+       char fname[128];

         if (dbgcfg->loaded)
                 return;

-       /* TODO: maybe add a per-device file? */
-       err = firmware_request_nowarn(&fw, "iwl-dbg-cfg.ini", dev);
+       snprintf(fname, 127, "iwl-dbg-cfg-%s.ini", dev_name(dev));
+       fname[127] = 0;
+
+       /* TODO: maybe add a per-device file?  Yes, did that. --Ben */

You probably don't need the comment anymore =)

+       err = firmware_request_nowarn(&fw, fname, dev);

Would it make sense to fall back to "iwl-dbg-cfg.ini" if the
per-device one isn't available?

It would be fine with me, lets see if Luca has any interest in the patches
in general before I go tweaking on them...

Thanks,
Ben


Thanks,



--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux