> I see lots of magic numbers in the driver like 2, 0x33 and 0x34 here. > Please convert the magic numbers to proper defines explaining the meaning. And for vendor commands you could even use enum to group them better in .h file somewhere. Hi Kalle, Thanks for reviewing the driver, We will work on the comments. Regards, Srini
