Search Linux Wireless

Re: [PATCH 1/2] mt76: usb: remove wake logic in mt76u_status_worker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Similar to mmio code path, remove wake logic in mt76u_status_worker
> handler

Starting from commit '90d494c99a99fa2eb858754345c4a9c851b409a0
("mt76: improve tx queue stop/wake")', the wake queue logic on
the usb status path is no longer necessary since the hw queues
are no longer stopped on the mt76 tx path.

Regards,
Lorenzo

> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> ---
>  drivers/net/wireless/mediatek/mt76/usb.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c
> index 81393788f98e..658b36a2281d 100644
> --- a/drivers/net/wireless/mediatek/mt76/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/usb.c
> @@ -811,7 +811,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
>  	struct mt76_dev *dev = container_of(usb, struct mt76_dev, usb);
>  	struct mt76_queue_entry entry;
>  	struct mt76_queue *q;
> -	bool wake;
>  	int i;
>  
>  	for (i = 0; i < IEEE80211_NUM_ACS; i++) {
> @@ -827,10 +826,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
>  			mt76_queue_tx_complete(dev, q, &entry);
>  		}
>  
> -		wake = q->stopped && q->queued < q->ndesc - 8;
> -		if (wake)
> -			q->stopped = false;
> -
>  		if (!q->queued)
>  			wake_up(&dev->tx_wait);
>  
> @@ -839,8 +834,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
>  		if (dev->drv->tx_status_data &&
>  		    !test_and_set_bit(MT76_READING_STATS, &dev->phy.state))
>  			queue_work(dev->wq, &dev->usb.stat_work);
> -		if (wake)
> -			ieee80211_wake_queue(dev->hw, i);
>  	}
>  }
>  
> -- 
> 2.28.0
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux