On 2020-12-17 12:54, Toke Høiland-Jørgensen wrote: > Felix Fietkau <nbd@xxxxxxxx> writes: > >> Depending on the source, a hardware calculated hash may not provide the >> same level of collision resistance. > > This seems like it would have performance implications? > > Also, this can potentially discard information from tunnels that > preserve the hash before encapsulation (we added support for this to > Wireguard which had some nice effects on queueing of encapsulated > traffic). If the hash was calculated in software using the flow dissector, it will be preserved, even if it went through a few virtual interfaces. The only hashes discarded are hardware generated ones. - Felix
