Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > The "if (!ret)" condition is inverted and it should be "if (ret)". It means > that we return success when we had intended to return an error code. This also > caused a spurious warning even when the suspend was successful: > > [ 297.186612] ath11k_pci 0000:06:00.0: failed to suspend hif: 0 > > Fixes: d1b0c33850d2 ("ath11k: implement suspend for QCA6390 PCI devices") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> 2 patches applied to ath-current branch of ath.git, thanks. 9b09456258ea ath11k: Fix error code in ath11k_core_suspend() 30d085039314 ath11k: Fix ath11k_pci_fix_l1ss() -- https://patchwork.kernel.org/project/linux-wireless/patch/X9nF17L2/EKOSbn/@mwanda/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches