On 2020-12-16 21:54, Johannes Berg wrote:
> On Wed, 2020-12-16 at 21:43 +0100, Felix Fietkau wrote:
>>
>> +static int fq_flow_drop(struct fq *fq, struct fq_flow *flow,
>> + fq_skb_free_t free_func)
>> +{
>> + unsigned int packets = 0, bytes = 0, truesize = 0;
>> + struct fq_tin *tin = flow->tin;
>> + struct sk_buff *skb;
>> + int pending;
>> +
>> + lockdep_assert_held(&fq->lock);
>> +
>> + pending = min_t(int, 32, skb_queue_len(&flow->queue) / 2);
>>
>
> Why 32?
I guess I forgot got make it configurable. sch_fq_codel uses 64, but
that seemed a bit excessive to me.
- Felix
