On 2020-12-16 22:04, Johannes Berg wrote: > Wait, another thing: > >> +++ b/net/mac80211/iface.c >> @@ -798,10 +798,21 @@ static bool ieee80211_set_sdata_offload_flags(struct ieee80211_sub_if_data *sdat >> flags &= ~IEEE80211_OFFLOAD_ENCAP_ENABLED; >> } >> >> + if (ieee80211_hw_check(&local->hw, SUPPORTS_RX_DECAP_OFFLOAD) && >> + ieee80211_iftype_supports_encap_offload(sdata->vif.type)) { >> + flags |= IEEE80211_OFFLOAD_DECAP_ENABLED; > > Why does decap depend on encap here? Supported for the same types, I didn't feel like duplicating the function. I guess I could rename it to ieee80211_iftype_supports_hdr_offload to make it more clear. - Felix