On Thu, Dec 10, 2020 at 7:09 AM Rakesh Pillai <pillair@xxxxxxxxxxxxxx> wrote: > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -1045,14 +1085,18 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar, > ret = ath10k_snoc_init_pipes(ar); > if (ret) { > ath10k_err(ar, "failed to initialize CE: %d\n", ret); > - goto err_wlan_enable; > + goto err_free_rri; > } > > return 0; > > -err_wlan_enable: > +err_free_rri: > + ath10k_ce_free_rri(ar); This change in the error path seems to be an unrelated (but correct) fix. It deserves its own patch, I think. Brian > ath10k_snoc_wlan_disable(ar); > > +err_hw_power_off: > + ath10k_hw_power_off(ar); > + > return ret; > } >