Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > 'const struct dev_pm_ops rtw_pm_ops' is declared by pci.c, and it should be > declare as 'extern' in pci.h. Without 'extern' causes every file including > pci.h has an individual instance of rtw_pm_ops but not reference to the one > declared in pci.c > > If kernel config, like test robot, doesn't build driver as module, it leads > multiple definition. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Fixes: 2e86ef413ab3 ("rtw88: pci: Add prototypes for .probe, .remove and .shutdown") > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Patch applied to wireless-drivers-next.git, thanks. 91aeaf09a6ee rtw88: fix multiple definition of rtw_pm_ops -- https://patchwork.kernel.org/project/linux-wireless/patch/20201208013746.11065-1-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches