On Mon, 2008-09-15 at 17:10 +0200, Holger Schurig wrote: > > So why does this need a new event? Can't wpa_supplicant > > monitor the signal quality (or level/noise if the driver > > doesn't provide "quality") and do what it needs to do without > > any changes to the kernel at all? > > It could, but to do this, wpa_supplicant (or whatever) would have > to periodically get awake, send the query command to mac80211 > and get the result. > > With an event, it just sits sleeping until some interesting event > arrives. Nicer programming idiom, AFAIK. Except that everything that listens to WEXT events gets woken up every time an event comes in anyway. So any card doing background scanning will wake up the supplicant too; I honestly think that every few seconds is OK here. BTW, make sure you rate-limit the background scanning events from mac80211 in your patches to every few seconds (I picked 4 for ipw2200) otherwise it floods events and wakes up everything all the time. My main problem is that adding a beacon threshold to mac80211 isn't a great idea because it's not a standard value and it's not something really applicable to mac80211; it's policy which is different for different programs, and the way you've implemented it here it's global for the interface. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
