On Thu, Nov 26, 2020 at 07:57:23AM +0100, Arend Van Spriel wrote: > On November 25, 2020 8:13:07 PM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > On Wed, Nov 25, 2020 at 01:33:00PM -0500, Brian O'Keefe wrote: > > > Macro names were derived from the Windows driver, as that was the best > > > available source. > > > > Why move these? What does this help with? > > Hi Greg, > > Most if not all SDIO-based (wifi) drivers in mainline have their venid and > devid definitions in that header file. So seems like a good idea to me, but > maybe not so for a staging driver? If the driver ever gets moved out, maybe do it then as part of that effort. I haven't seen that happening, so I would recommend just leaving this alone for now. thanks, greg k-h
