Search Linux Wireless

Re: [PATCH 09/10] rtw88: coex: upgrade coexistence A2DP mechanism

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[cannot apply to wireless-drivers/master v5.10-rc5 next-20201124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/pkshih-realtek-com/rtw88-coex-enhance-coex-performance-and-synchronize-coex-code/20201125-134530
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/2bb188c0b2a868bfbfed40d5cd7741421b40dabb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review pkshih-realtek-com/rtw88-coex-enhance-coex-performance-and-synchronize-coex-code/20201125-134530
        git checkout 2bb188c0b2a868bfbfed40d5cd7741421b40dabb
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/realtek/rtw88/coex.c: In function 'rtw_coex_action_bt_relink':
>> drivers/net/wireless/realtek/rtw88/coex.c:1535:6: warning: variable 'slot_type' set but not used [-Wunused-but-set-variable]
    1535 |  u32 slot_type = 0;
         |      ^~~~~~~~~
   drivers/net/wireless/realtek/rtw88/coex.c: In function 'rtw_coex_action_bt_hid':
   drivers/net/wireless/realtek/rtw88/coex.c:1782:37: warning: variable 'is_toggle_table' set but not used [-Wunused-but-set-variable]
    1782 |  bool bt_multi_link_remain = false, is_toggle_table = false;
         |                                     ^~~~~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/coex.c:1780:6: warning: variable 'wl_bw' set but not used [-Wunused-but-set-variable]
    1780 |  u32 wl_bw;
         |      ^~~~~
   drivers/net/wireless/realtek/rtw88/coex.c: In function 'rtw_coex_action_bt_a2dp_hid':
   drivers/net/wireless/realtek/rtw88/coex.c:1981:7: warning: variable 'is_toggle_table' set but not used [-Wunused-but-set-variable]
    1981 |  bool is_toggle_table = false;
         |       ^~~~~~~~~~~~~~~

vim +/slot_type +1535 drivers/net/wireless/realtek/rtw88/coex.c

  1527	
  1528	static void rtw_coex_action_bt_relink(struct rtw_dev *rtwdev)
  1529	{
  1530		struct rtw_coex *coex = &rtwdev->coex;
  1531		struct rtw_coex_stat *coex_stat = &coex->stat;
  1532		struct rtw_efuse *efuse = &rtwdev->efuse;
  1533		struct rtw_chip_info *chip = rtwdev->chip;
  1534		u8 table_case, tdma_case;
> 1535		u32 slot_type = 0;
  1536	
  1537		rtw_dbg(rtwdev, RTW_DBG_COEX, "[BTCoex], %s()\n", __func__);
  1538	
  1539		rtw_coex_set_ant_path(rtwdev, false, COEX_SET_ANT_2G);
  1540		rtw_coex_set_rf_para(rtwdev, chip->wl_rf_para_rx[0]);
  1541	
  1542		if (efuse->share_ant) { /* Shared-Ant */
  1543			if (coex_stat->wl_gl_busy) {
  1544				table_case = 26;
  1545				if (coex_stat->bt_hid_exist &&
  1546				    coex_stat->bt_profile_num == 1) {
  1547					slot_type = TDMA_4SLOT;
  1548					tdma_case = 20;
  1549				} else {
  1550					tdma_case = 20;
  1551				}
  1552			} else {
  1553				table_case = 1;
  1554				tdma_case = 0;
  1555			}
  1556		} else { /* Non-Shared-Ant */
  1557			if (coex_stat->wl_gl_busy)
  1558				table_case = 115;
  1559			else
  1560				table_case = 100;
  1561			tdma_case = 100;
  1562		}
  1563	
  1564		rtw_coex_table(rtwdev, false, table_case);
  1565		rtw_coex_tdma(rtwdev, false, tdma_case);
  1566	}
  1567	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux