Hi, This patch looks good to me, there is one small nit, If the maintainer can take care of it then probably we don't need a new rev. > @@ -329,6 +336,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = { > .fw_diag_ce_download = true, > .tx_stats_over_pktlog = false, > .supports_peer_stats_info = true, > + .dynamic_sar_support = true, > }, Orthogonal to this patch, other people might probably differ, I guess putting dynamic sar support as a firmware feature capability should be more scalable and then we don't need a structure table for each firmware. This might hold for other firmware features as well. > + ath10k_dbg(ar, ATH10K_DBG_MAC, "mac txpower 2g:%d 5g:%d\n", > + tx_power_2g, tx_power_5g); just a nit: space after colon. This might throw a warning in checkpatch.pl -Abhishek