Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable

[Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx>]

On 11/12/2020 11:55 AM, Wen Gong wrote:
> On 2017-03-08 21:20, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@xxxxxxxxx>

[...]

> > @@ -2685,6 +2686,21 @@ static int ieee80211_set_bitrate_mask(struct
> > wiphy *wiphy,
> >              return ret;
> >      }
> >
> > +    /*
> > +     * If active validate the setting and reject it if it doesn't leave
> > +     * at least one basic rate usable, since we really have to be able
> > +     * to send something, and if we're an AP we have to be able to do
> > +     * so at a basic rate so that all clients can receive it.
> > +     */
> > +    if (rcu_access_pointer(sdata->vif.chanctx_conf) &&
> > +        sdata->vif.bss_conf.chandef.chan) {
> > +        u32 basic_rates = sdata->vif.bss_conf.basic_rates;
> > +        enum nl80211_band band = sdata->vif.bss_conf.chandef.chan->band;
> > +
> > +        if (!(mask->control[band].legacy & basic_rates))
> > +            return -EINVAL;
> If user want to use “iw wlan0 set bitrates legacy-5 54” to set it to 
> fixed in 54M and 54M is
> not basic rate in AP's becaon as example of below, then the iw command 
> will fail.

Which was the intent of this change, wasn't it? You want to allow anyway 
or you want a clear error message as to why it fails?

Regards,
Arend

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature