Search Linux Wireless

Re: [PATCH v2] mac80211: fix virtual interfaces vs. injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> waiting for the compile to finish (just in case it doesn't) is often
> useful...

This still has a bug! I suck. Here's an incremental fix.


Subject: mac80211: fix device refcount bug

mac80211 is releasing the reference of the wrong interface here.

Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
---
 net/mac80211/tx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- everything.orig/net/mac80211/tx.c	2008-09-12 16:40:12.000000000 +0200
+++ everything/net/mac80211/tx.c	2008-09-12 16:40:37.000000000 +0200
@@ -1381,8 +1381,8 @@ int ieee80211_master_start_xmit(struct s
 						       hdr->addr2)) {
 					dev_hold(sdata->dev);
 					dev_put(odev);
-					odev = osdata->dev;
 					osdata = sdata;
+					odev = osdata->dev;
 					skb->iif = sdata->dev->ifindex;
 					monitor_iface = FOUND_SDATA;
 					break;


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux