On Fri, Sep 12, 2008 at 11:46:36AM -0700, Larry Finger wrote: > Luis R. Rodriguez wrote: > > On Fri, Sep 12, 2008 at 10:37:26AM -0700, Larry Finger wrote: > >> After pulling the latest git from wireless-testing, my wireless > >> failed. I bisected this to be commit > >> 544ec9a11fdef5142a76a8eb4b186a80a272c035, "cfg80211: Add new wireless > >> regulatory infrastructure". > --snip-- > > > > Please apply johill's patch, "[PATCH] cfg80211: fix regdomain macro" > > That patch fixed the problem. For someone following this thread, the > patch is by Johannes Berg. > > I can understand when some oddball hardware causes a corner-case > problem - I just had one with an ancient laptop - but somehow, I > expect that most people will use the old regulatory option, at least > for a while. Shouldn't the most rudimentary testing have caught this > problem? Well no, IMHO people *should not* use the old regulatory stuff if possible, the idea is to kill it ASAP, you should only use the old regulatory stuff if you *need* to, meaning you have some dependency on the old module parameter for some strange odd ball reason or if you cannot compile and install crda or iw. But yes, you are right testing should have caught this, and I appologize for that. Thing is I have crda installed and if you have it you won't see this issue as this macro is only used for the static regulatory domains. But yes, I should have caught it. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
