Apologies for the delay, was busy so could not work on V2 . I have started working on V2 patch. Will upload by today/tomorrow. Abhishek On Thu, Nov 5, 2020 at 11:11 PM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > Abhishek Kumar <kuabhs@xxxxxxxxxxxx> wrote: > > > In some devices difference in chip-id should be enough to pick > > the right BDF. Add another support for chip-id based BDF selection. > > With this new option, ath10k supports 2 fallback options. > > > > The board name with chip-id as option looks as follows > > board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320' > > > > Signed-off-by: Abhishek Kumar <kuabhs@xxxxxxxxxxxx> > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Tested-by: Abhishek Kumar <kuabhs@xxxxxxxxxxxx> > > There were few checkpatch warnings which I fixed: > > $ ath10k-check > drivers/net/wireless/ath/ath10k/core.c:1501: Alignment should match open parenthesis > drivers/net/wireless/ath/ath10k/core.c:1512: line length of 92 exceeds 90 columns > drivers/net/wireless/ath/ath10k/core.c:1521: line length of 92 exceeds 90 columns > > The first one was also what Doug commented. I also added Tested-on tags, > thanks for those. The updated patch is in pending branch (soon). > > But is this patch ok to take now? I didn't quite get the conclusion of the > discussion. > > -- > https://patchwork.kernel.org/project/linux-wireless/patch/20201020000506.1.Ifbc28707942179f1cefc7491e995814564495270@changeid/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches >
