On Mon, 2020-11-09 at 13:11 +0200, Kalle Valo wrote: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > Remove all the code that was there to configure WDS interfaces, > > now that there's no way to reach it anymore. > > > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > > [...] > > > @@ -675,10 +673,8 @@ int wiphy_register(struct wiphy *wiphy) > > !(wiphy->nan_supported_bands & BIT(NL80211_BAND_2GHZ))))) > > return -EINVAL; > > > > -#ifndef CONFIG_WIRELESS_WDS > > if (WARN_ON(wiphy->interface_modes & BIT(NL80211_IFTYPE_WDS))) > > return -EINVAL; > > -#endif > > What about out-of-tree drivers? Should we have (or do we already have?) > a some kind safe guard if an out of tree driver tries to use WDS? That's what happens here, no? We warn and return invalid - now unconditionally, before we allowed it if CONFIG_WIRELESS_WDS was enabled. johannes
