Search Linux Wireless

Re: [PATCH 1/8] orinoco: Remove BUG_ON(in_interrupt/irq())

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote:

> The usage of in_irq()/in_interrupt() in drivers is phased out and the
> BUG_ON()'s based on those are not covering all contexts in which these
> functions cannot be called.
> 
> Aside of that BUG_ON() should only be used as last resort, which is clearly
> not the case here.
> 
> A broad variety of checks in the invoked functions (always enabled or debug
> option dependent) cover these conditions already, so the BUG_ON()'s do not
> really provide additional value.
> 
> Just remove them.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx

8 patches applied to wireless-drivers-next.git, thanks.

ce4dd05cbba6 orinoco: Remove BUG_ON(in_interrupt/irq())
24bf941f2c96 airo: Invoke airo_read_wireless_stats() directly
49eb01995285 airo: Always use JOB_STATS and JOB_EVENT
494e46d08d35 airo: Replace in_atomic() usage.
7534fd5e5834 hostap: Remove in_atomic() check.
abcda807d868 zd1211rw: Remove in_atomic() usage.
317f688b0a54 rtlwifi: Remove in_interrupt() usage in is_any_client_connect_to_ap().
50c61ae15865 rtlwifi: Remove in_interrupt() usage in halbtc_send_bt_mp_operation()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20201101211536.2966644-2-bigeasy@xxxxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux