On Tue, 2020-11-03 at 10:34 +0800, Carl Huang wrote: > On 2020-10-31 10:46, Abhishek Kumar wrote: > > From: kuabhs@xxxxxxxxxxxx > > > > There are few more additional comments here. > > > + * @NL80211_CMD_SET_SAR_SPECS: SAR power limitation configuration is > > > + * passed using %NL80211_ATTR_SAR_SPEC. > > > + * > > > > This command requires NL80211_ATTR_IFINDEX, probably should be better > > to add > > this in the comment ? > > > Per Johannes's comments, this explicit index is not required. Are you > fine with it? > > Instead, user-space application records the array index when querying > the SAR > capability. When set, the nested array index will be used to set the > power. > This requires user-space has a strict mapping of index. and > NL80211_ATTR_IFINDEX > is to be removed. Wait, what? The IFINDEX is still required, that identifies the interface - though it probably shouldn't be required, this should be per wiphy, so you could also use ATTR_WIPHY_IDX? You're thinking of ... something else. NL80211_SAR_ATTR_SPECS_FREQ_RANGE_INDEX perhaps? johannes
