On November 2, 2020 6:15:32 PM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> writes:There are missig brcmf_free() for brcmf_alloc(). Fix memory leak by adding missed brcmf_free(). Reported-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and brcmf_detach() functions")This should be:Fixes: 450914c39f88 ("brcmfmac: split brcmf_attach() and brcmf_detach() functions")But I can fix that, no need to resend because of this.
Hi Kalle,But this is not the commit that needs fixing as I mentioned before. Instead it should be a1f5aac1765af ("brcmfmac: don't realloc wiphy during PCIe reset") which introduced the actual memory leak.
Regards, Arend
-- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
