On Thu, Sep 11, 2008 at 10:13:20AM -0700, Anna Neal wrote: > On Thu, Sep 11, 2008 at 10:03 AM, Anna Neal <anna@xxxxxxxxxxx> wrote: > > On Thu, Sep 11, 2008 at 8:34 AM, Dan Williams <dcbw@xxxxxxxxxx> wrote: > >> On Wed, 2008-09-10 at 16:45 -0700, Anna Neal wrote: > >>> Improved the tx power control configuration per Dan Williams suggestions. Added > >>> a firmware version check because the current implementation will only work for > >>> below version 9. > >>> > >>> Signed-off-by: Anna Neal <anna@xxxxxxxxxxx> > >> > >> One more round, sorry! :) > >> > >> First, until the patch has actually been applied, could you post > >> complete diffs? This is a patch against the previous patch, but it's > >> best to keep the whole patch together until it's committed by John to > >> the master wireless tree. > >> > >> Second, since you get to respin the patch anyway for this, the TPC > >> Config stuff should be just fine on V9+ firmware, only the > >> POWER_ADAPT_CFG command is incompatible on V9+. I probably wasn't clear > >> enough about this yesterday. Any chance you could move the TPC config > >> commands out of the firmware check and just the PACFG ones < V9? > >> > >> Thanks! > >> Dan > > > > No problem, will send a new patch later today. > > > > I just wanted to point out that it seems the original patch was > > already committed by John. > > > > Here is the link: > > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commith=cdd799f13e3a2a47b501286551ba9386e8936272 > > > > Thanks, > > Anna > > I'm sorry, I sent a bad link. > > Here is a good one. > > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commit&h=cdd799f13e3a2a47b501286551ba9386e8936272 FWIW, it hasn't been sent to Dave M. yet -- it's only in wireless-testing. That said, I'm fine with either a whole new patch or the incremental one. But if Dan wants a new one and you don't mind... John -- John W. Linville linville@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
