Search Linux Wireless

Re: [PATCH 04/11] rtw88: coex: coding style adjustment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master v5.9 next-20201023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/pkshih-realtek-com/rtw88-coex-fix-field-issues-and-add-debug-interfaces/20201023-174021
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: x86_64-randconfig-r022-20201023 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 147b9497e79a98a8614b2b5eb4ba653b44f6b6f0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/946944e605505fe42a9b75978ea4953a3267bc8c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review pkshih-realtek-com/rtw88-coex-fix-field-issues-and-add-debug-interfaces/20201023-174021
        git checkout 946944e605505fe42a9b75978ea4953a3267bc8c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/realtek/rtw88/coex.c:2523:6: warning: no previous prototype for function 'rtw_coex_coex_dm_reset' [-Wmissing-prototypes]
   void rtw_coex_coex_dm_reset(struct rtw_dev *rtwdev)
        ^
   drivers/net/wireless/realtek/rtw88/coex.c:2523:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void rtw_coex_coex_dm_reset(struct rtw_dev *rtwdev)
   ^
   static 
   1 warning generated.

vim +/rtw_coex_coex_dm_reset +2523 drivers/net/wireless/realtek/rtw88/coex.c

  2522	
> 2523	void rtw_coex_coex_dm_reset(struct rtw_dev *rtwdev)
  2524	{
  2525		__rtw_coex_init_hw_config(rtwdev, false);
  2526	}
  2527	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux