On Thu, 2008-09-11 at 09:50 -0700, Luis R. Rodriguez wrote: > > I had actually tried > > (http://johannes.sipsolutions.net/patches/kernel/ath9k-sta-node.patch) > > but you're using refcounting for the nodes while mac80211 RCU-protects > > them, so I didn't get very far. > > Good thing I read RCU docs yesterday. Heh. > We should be able to remove ref counts and simply use RCU and > sychronize_rcu() before deletion. Well you don't get to control deletion then, that's another thing. > > It needs a bit more effort to make sure > > you don't have node pointers stick around in some tx descriptor after > > mac80211 decides to remove a node (which may very well happen while > > frames are queued) > > We can call_rcu() here no, and let the driver deal with what it needs to > prior to deletion? The driver already gets notified via sta_notify() that the sta is about to be deleted, it must make sure that no matter what sort of references it kept, the sta will not be accessed after that sta_notify call. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
