Search Linux Wireless

Re: [PATCH] wireless: remove unneeded break

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/10/2020 17:05, trix@xxxxxxxxxx wrote:
From: Tom Rix <trix@xxxxxxxxxx>

A break is not needed if it is preceded by a return or goto

Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

diff --git a/drivers/net/wireless/intersil/p54/eeprom.c b/drivers/net/wireless/intersil/p54/eeprom.c
index 5bd35c147e19..3ca9d26df174 100644
--- a/drivers/net/wireless/intersil/p54/eeprom.c
+++ b/drivers/net/wireless/intersil/p54/eeprom.c
@@ -870,7 +870,6 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
  			} else {
  				goto good_eeprom;
  			}
-			break;
Won't the compiler (gcc) now complain about a missing fallthrough annotation?
  		default:
  			break;
  		}

Cheers,
Christian



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux