On 2020-10-08 02:09, Johannes Berg wrote:
On Thu, 2020-10-08 at 11:06 +0200, Johannes Berg wrote:
On Sat, 2020-10-03 at 14:57 -0700, Rajkumar Manoharan wrote:
> This allows an option to configure a single HE MCS beacon tx rate.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxx>
> ---
> v2: clear mcs ratemask when beacon tx rate is not set.
I can't believe I didn't realize this before, but ...
Never mind that comment ... it wasn't there before, I was confused :)
No worries. :)
I mean, why not just skip the
/* Default to all rates enabled */
for (i = 0; i < NUM_NL80211_BANDS; i++) {
[...]
}
code? Right now you're first setting it, and then clearing it again
when
is_beacon_tx_rate is set ...
I'd prefer a "default_all_enabled" parameter, and then call the above
loop conditionally on it (perhaps moving it to a separate function to
not have all the deep indentation to worry about).
And maybe that should be a separate patch.
Neat.. Will split the patch and send a new series.
-Rajkumar
