Hello Ulf, On Friday 16 October 2020 13:30:30 CEST Ulf Hansson wrote: > On Mon, 12 Oct 2020 at 12:47, Jerome Pouiller > <Jerome.Pouiller@xxxxxxxxxx> wrote: > > > > From: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> > > Please fill out this commit message to explain a bit more about the > patch and the HW it enables support for. This patch belongs to a series[1] that will squashed before to be committed (Kalle Valo prefer to process like that for this review). So, I didn't bother to write real commit messages. For the v2, I will take care to add linux-mmc in copy of the whole series. [1] https://lore.kernel.org/lkml/20201012104648.985256-1-Jerome.Pouiller@xxxxxxxxxx/ > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> > > --- > > drivers/net/wireless/silabs/wfx/bus_sdio.c | 269 +++++++++++++++++++++ > > 1 file changed, 269 insertions(+) > > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c > > > > diff --git a/drivers/net/wireless/silabs/wfx/bus_sdio.c b/drivers/net/wireless/silabs/wfx/bus_sdio.c > > new file mode 100644 > > index 000000000000..e06d7e1ebe9c [...] > > +struct sdio_driver wfx_sdio_driver = { > > + .name = "wfx-sdio", > > + .id_table = wfx_sdio_ids, > > + .probe = wfx_sdio_probe, > > + .remove = wfx_sdio_remove, > > + .drv = { > > + .owner = THIS_MODULE, > > + .of_match_table = wfx_sdio_of_match, > > + } > > +}; > > I couldn't find where you call sdio_register|unregister_driver(), but > maybe that's done from another patch in series? Indeed, it is here[2]. [2] https://lore.kernel.org/lkml/20201012104648.985256-5-Jerome.Pouiller@xxxxxxxxxx/ -- Jérôme Pouiller
