Search Linux Wireless

Re: [PATCH 02/13] iwlwifi: pcie: fix the xtal latency value for a few qu devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Luca Coelho <luca@xxxxxxxxx> writes:

> On Thu, 2020-10-08 at 18:47 +0300, Kalle Valo wrote:
>> Luca Coelho <luca@xxxxxxxxx> writes:
>> 
>> > From: Luca Coelho <luciano.coelho@xxxxxxxxx>
>> > 
>> > We were using 5 ms for some qu devices, but their xtal stabilizes
>> > much faster than that.  Reduce the value to 500 ms.
>> > 
>> > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
>> > ---
>> >  drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > 
>> > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>> > index 60e0640d07dc..8b97c2eb2632 100644
>> > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>> > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>> > @@ -253,7 +253,7 @@ const struct iwl_cfg_trans_params iwl_qu_trans_cfg = {
>> >  	.device_family = IWL_DEVICE_FAMILY_22000,
>> >  	.base_params = &iwl_22000_base_params,
>> >  	.integrated = true,
>> > -	.xtal_latency = 5000,
>> > +	.xtal_latency = 500,
>> >  	.ltr_delay = IWL_CFG_TRANS_LTR_DELAY_200US,
>> >  };
>> 
>> The commit log doesn't make sense, I'll do s/5 ms/5 s/ during commit.
>
> Hmmm, indeed it doesn't make sense like that.  But I actually think the
> 5 ms is correct, but the other one should be 500 microseconds.

Oh, didn't think of that. And it's too late to fix it now.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux