Wright Feng <wright.feng@xxxxxxxxxxx> writes: > From: Kurt Lee <kurt.lee@xxxxxxxxxxx> > > Let driver parse DPP frames from upper layer and do corresponding > configuration to firmware. > > Signed-off-by: Kurt Lee <kurt.lee@xxxxxxxxxxx> Wright's s-o-b missing. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > @@ -63,6 +63,9 @@ > #define RSN_CAP_MFPC_MASK BIT(7) > #define RSN_PMKID_COUNT_LEN 2 > > +#define DPP_AKM_SUITE_TYPE 2 > +#define WLAN_AKM_SUITE_DPP SUITE(WLAN_OUI_WFA, DPP_AKM_SUITE_TYPE) Shouldn't these be in include/linux/ieee80211.h? > --- a/drivers/net/wireless/broadcom/brcm80211/include/brcmu_wifi.h > +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcmu_wifi.h > @@ -233,6 +233,11 @@ static inline bool ac_bitmap_tst(u8 bitmap, int prec) > > #define WPA3_AUTH_SAE_PSK 0x40000 /* SAE with 4-way handshake */ > > +#define WFA_AUTH_DPP 0x200000 /* WFA DPP AUTH */ I assume this is Broadcom specific and this is the correct file for this define. Please correct me if I'm wrong. > +#define WFA_OUI "\x50\x6F\x9A" /* WFA OUI */ You should use this: include/linux/ieee80211.h:#define WLAN_OUI_WFA 0x506f9a > +#define DPP_VER 0x1A /* WFA DPP v1.0 */ Shouldn't this be also in include/linux/ieee80211.h? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
