On Tue, Sep 29, 2020 at 10:25:30PM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > > kaweth_control() is almost the same as usb_control_msg() except for the > memory allocation mode (GFP_ATOMIC vs GFP_NOIO) and the in_interrupt() > check. > > All the invocations of kaweth_control() are within the probe function in > fully preemtible context so there is no reason to use atomic allocations, > GFP_NOIO which is used by usb_control_msg() is perfectly fine. > > Replace kaweth_control() invocations from probe with usb_control_msg(). > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Note, the usb_control_msg_send/recv() new functions that will show up in 5.10-rc1 will help a bit with this logic, but for what you have now, this is fine, nice cleanups. Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
