On 2020-09-27 18:27, Lorenzo Bianconi wrote: >> >> On 2020-09-26 17:22, Lorenzo Bianconi wrote: >> > In order to reduce cpu cycles, enable hw beacon filter by default if the >> > device is running offload fw >> > >> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> >> The beacon filtering part and runtime pm needs to take into account that >> there could be more than one vif and we might be running an AP as well. >> >> - Felix >> > > Do you mean we should run mt7615_mcu_set_bss_pm() for other vif types, e.g. AP? > IIUC the fw can manage the rx beacon offload even for other modes. > > @Sean: do we need to send any other message to mcu for rx beacon > offload for AP mode? Can the fw properly manage it? I think we need to clear MT_WF_RFCR_DROP_OTHER_BEACON (since it's a global bit) and maybe also dev->pm.enable if we have an active interface that is not in client mode. - Felix