Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes: > Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > >> In order to get 802.11ac working the way we want, additional parameters >> need to be passed down to the firmware. >> >> This patch takes the full remaining set of parameters defined in the >> downstream riva/inc/wlan_hal_cfg.h and imports them into hal.h with some >> minor name length adjustments. >> >> This addition will allow us to pass a larger firmware configuration set >> later on. >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> >> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > > 4 patches applied to ath-next branch of ath.git, thanks. > > 8ec5568b4e2e wcn36xx: Extend HAL param config list > 3e977c5c523d wcn36xx: Define wcn3680 specific firmware parameters > 2f0c0e3b856d wcn36xx: Add ability to download wcn3680 specific firmware parameters > 52054ebd0532 wcn36xx: Latch VHT specific BSS parameters to firmware Here also the first three patches could have been easily just one patch. And the last patch, adding just one function call, most likely could have been merged with some other patches. The problem with splitting the patches to this small size is that it's hard to review. I don't see the context and have to jump around between patches to understand what's happening. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
