On Fri, 2020-09-18 at 19:13 +0200, Alexander Wetzel wrote:
>
> + /* GCMP and 256 bit CCMP keys the key can't be copied into the
> + * MPDU struct ieee80211_tx_info. We therefore must flush the
> + * queues to ensure there are no MPDUs left which are referring
> + * to the outgoing key.
> + */
> + if (key->flags & IEEE80211_KEY_FLAG_PAIRWISE &&
> + (key->cipher == WLAN_CIPHER_SUITE_GCMP ||
> + key->cipher == WLAN_CIPHER_SUITE_GCMP_256 ||
> + key->cipher == WLAN_CIPHER_SUITE_CCMP_256)) {
> + ieee80211_stop_queues(hw);
> + iwl_mvm_mac_flush(hw, vif, 0, true);
> + ieee80211_wake_queues(hw);
> + }
Shouldn't the wake be after installing the new key? Otherwise new frames
can race and be there again?
johannes
